feat: table in RB#732
Merged
Merged
Conversation
added 2 commits
May 7, 2025 18:28
whoami-amrit
requested review from
vikramdevtron and
vivek-devtron
as code owners
RohitRaj011
suggested changes
May 15, 2025
RohitRaj011
previously approved these changes
May 20, 2025
feat(types): add ResourceRecommender to Nodes enum
…types for resource recommendations
…e null values for current, recommended, and delta
…I version strings
feat(ResourceBrowser): enhance K8sResourceDetailDataType and add RESOURCE_RECOMMENDER_HEADER_TO_TITLE_MAP
… apply resource recommendation modal
…ent and recommended fields
…clude loading states and error handling
AbhishekA1509
requested changes
Jun 30, 2025
whoami-amrit
changed the base branch from
feat/resource-recommender-develop
to
develop
Co-authored-by: Abhishek <abhishek@devtron.ai>
vivek-devtron
previously approved these changes
Jul 2, 2025
AbhishekA1509
previously approved these changes
Jul 2, 2025
fix: rb table
whoami-amrit
dismissed stale reviews from AbhishekA1509 and vivek-devtron
via
fbb3975
…ib into feat/rb-table
vivek-devtron
approved these changes
Jul 2, 2025
whoami-amrit
dismissed
RohitRaj011’s stale review
Need to merge into develop for packet testing will verify later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist